Adwaita: bring more attention to focus change
authorJakub Steiner <jimmac@gmail.com>
Thu, 30 Apr 2020 20:40:21 +0000 (22:40 +0200)
committerJakub Steiner <jimmac@gmail.com>
Thu, 30 Apr 2020 22:14:44 +0000 (00:14 +0200)
- as discussed in https://gitlab.gnome.org/GNOME/gtk/-/issues/2644 it's desirable to bring attention to what's focused. Instead of pressing `alt` just simply changing focus with `tab` can have a similar effect

Extends https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/1802

gtk/theme/Adwaita/_common.scss
gtk/theme/Adwaita/_drawing.scss

index 3612b011f93b48c112fb42fa73988fcea0925ca2..ba1e6738dd83408ee4d37cf81fa9ed0f89f7da90 100644 (file)
@@ -3876,7 +3876,7 @@ colorswatch {
 
   transition: $focus_transition;
 
-  @include focus-ring();
+  @include focus-ring($width: 4px, $offset: -2px);
 
   &:drop(active), & { border-style: none; } // FIXME: implement a proper drop(active) state
 
index 7e67786f1a3761d87296aadc8b08ba98f7c561c2..4bb7d97d5c33702e825d32e5c417dd6d3d1cc74a 100644 (file)
 //
 @mixin focus-ring($target: null, $width: 2px, $offset: -$width, $outer: false) {
   & #{$target} {
-    outline: 0 solid $focus_border_color;
-    outline-offset: if($outer, $offset, $offset + $width);
+    outline: 0 solid transparent;
+    outline-offset: if($outer, $offset + 10px, $offset + $width + 10px);
   }
 
   &:focus:focus-visible #{$target} {
+    outline-color: $focus_border_color;
     outline-width: $width;
     outline-offset: $offset;
   }